https://bugzilla.redhat.com/show_bug.cgi?id=1379090 --- Comment #8 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Mukundan Ragavan from comment #7) > (In reply to gil cattaneo from comment #6) > > (In reply to Mukundan Ragavan from comment #4) > > > (In reply to gil cattaneo from comment #3) > > > > Issues: > > > > > > > > [?]: License field in the package spec file matches the actual license. > > > > Note: Checking patched sources after %prep for licenses. Licenses > > > > found: "BSD (3 clause)", "Unknown or generated". 47 files have unknown > > > > license. Detailed output of licensecheck in /home/gil/1379090-python- > > > > qtconsole/licensecheck.txt > > > > > > > > Some file report this license header: > > > > "Copyright (c) Jupyter Development Team. > > > > Distributed under the terms of the Modified BSD License." > > > > but most of the sources file are devoid of this information. > > > > Please, contact upstream and ask to confirm the licensing of code and/or > > > > content/s, and add license headers > > > > > > > > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > > > > LicensingGuidelines#License_Clarification > > > > https://github.com/jupyter/qtconsole/issues > > > > > > I will file a report with upstream. > > > > Waiting for upstream response if this do not take too much time ... > > (you can provides a PR for fix the problem ...?) > > > https://github.com/jupyter/qtconsole/issues/142 > > This is the issue I filed. But, I guess, I can do a PR (based on what reply > I get). > > I would imagine, since the license is clearly spelled out, this should not > be a problem? > > > > > > > > > > > > > > [!]: Package contains desktop file if it is a GUI application. > > > > ./qtconsole-4.2.1/examples/jupyter-qtconsole.desktop > > > > > > > > > > Fixed. > > > > Missing scripts, see > > https://fedoraproject.org/wiki/Packaging:Scriptlets#desktop-database > > This is embarassing! :( > > Fixed here. > https://nonamedotc.fedorapeople.org/pkgreview/python-packages/python- > qtconsole/round3/python-qtconsole.spec maybe os better: %post -n python2-%{pypi_name} /usr/bin/update-desktop-database &> /dev/null || : %postun -n python2-%{pypi_name} /usr/bin/update-desktop-database &> /dev/null || : %post -n python3-%{pypi_name} /usr/bin/update-desktop-database &> /dev/null || : %postun -n python3-%{pypi_name} /usr/bin/update-desktop-database &> /dev/null || : -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx