https://bugzilla.redhat.com/show_bug.cgi?id=1379090 --- Comment #4 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- (In reply to gil cattaneo from comment #3) > Issues: > > [?]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "BSD (3 clause)", "Unknown or generated". 47 files have unknown > license. Detailed output of licensecheck in /home/gil/1379090-python- > qtconsole/licensecheck.txt > > Some file report this license header: > "Copyright (c) Jupyter Development Team. > Distributed under the terms of the Modified BSD License." > but most of the sources file are devoid of this information. > Please, contact upstream and ask to confirm the licensing of code and/or > content/s, and add license headers > > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/ > LicensingGuidelines#License_Clarification > https://github.com/jupyter/qtconsole/issues I will file a report with upstream. > > [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/lib/python3.5/site-packages/qtconsole, > /usr/lib/python2.7/site-packages/qtconsole > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/lib/python3.5/site- > packages/qtconsole, /usr/lib/python2.7/site-packages/qtconsole > Fixed. > > [!]: Package contains desktop file if it is a GUI application. > ./qtconsole-4.2.1/examples/jupyter-qtconsole.desktop > Fixed. > Please, fix also these rpmlint problem: > python2-qtconsole.noarch: W: spelling-error %description -l en_US Qtbased -> > Qt based, Qt-based, Based > > python3-qtconsole.noarch: W: spelling-error %description -l en_US Qtbased -> > Qt based, Qt-based, Based > > python-qtconsole-doc.noarch: W: summary-not-capitalized C qtconsole > documentation Fixed. > python-qtconsole-doc.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/python-qtconsole-doc/html/objects.inv > python-qtconsole-doc.noarch: W: file-not-utf8 > /usr/share/doc/python-qtconsole-doc/html/objects.inv > I don't think this is a valid warning in this case - at least as far as I can tell. objects.inv is a sphinx generated compressed file. http://sphinx-objectsinv-encoderdecoder.readthedocs.io/en/latest/syntax.html > python-qtconsole.src: W: spelling-error %description -l en_US Qtbased -> Qt > based, Qt-based, Based Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx