[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1362490



--- Comment #24 from Jared Smith <jsmith.fedora@xxxxxxxxx> ---
You're going to need to adjust the license tag on this package.  Licensecheck
found several licenses other than Apache in parts of the code base:

GPL (v3 or later)
-----------------
libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/support/xhpast/parser.yacc.cpp
libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/support/xhpast/parser.yacc.hpp

MIT/X11 (BSD like)
------------------
libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/externals/jsonlint/LICENSE

You should also set the Version: tag to 0 and the Release: tag to
0.1.20160806.git%{git_short_version_hash}%{dist} 

If you were to do a second build with that same git hash, it would then be
0.2.20160806.git%{git_short_version_hash}%{dist}, and so on.

This way, if/when a version 1.0 comes out, it will be greater than version
0.x.2016whatever.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]