[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1378860

gil cattaneo <puntogil@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |puntogil@xxxxxxxxx



--- Comment #1 from gil cattaneo <puntogil@xxxxxxxxx> ---
hi
sorry for the noise, some hints:
License field is wrong:
EPL-1.0
-------
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/Group.java
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/Passwd.java
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/RLimit.java
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/SetUID.java
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/SetUIDListener.java
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-java/src/main/java/org/eclipse/jetty/setuid/SetUIDServer.java
jetty.toolchain-jetty-setuid-1.0.3/jetty-setuid/jetty-setuid-native/src/main/resources/org_eclipse_jetty_setuid_SetUID.c
rpmlint output:
Checking: jetty-setuid-1.0.3-1.fc26.i686.rpm
          jetty-setuid-javadoc-1.0.3-1.fc26.i686.rpm
          jetty-setuid-1.0.3-1.fc26.src.rpm
jetty-setuid.i686: W: unstripped-binary-or-object
/usr/lib/java/jetty-setuid/libsetuid-linux.so
jetty-setuid.i686: E: missing-call-to-setgroups-before-setuid
/usr/lib/java/jetty-setuid/libsetuid-linux.so
jetty-setuid.src: W: file-size-mismatch LICENSE-eplv10-aslv20.html = 280721,
https://raw.githubusercontent.com/eclipse/jetty.project/jetty-9.3.x/LICENSE-eplv10-aslv20.html
= 30012
3 packages and 0 specfiles checked; 1 errors, 2 warnings.

libsetuid-linux have these entries:

<jetty-setuid-linkerStartOption>-shared -lc
-ldl</jetty-setuid-linkerStartOption>
maybe you shoukd change with:
<jetty-setuid-linkerStartOption>-Wl --as-needed -lc
-ldl</jetty-setuid-linkerStartOption>
for avoid "unused-direct-shlib-dependency and undefined-non-weak-symbol"

jetty-setuid-native artifact contains only the generated C files used for build
the jni library only, maybe you could remove

       <artifactId>maven-dependency-plugin</artifactId>
        <executions>
          <execution>
            <id>unpack</id>
            <phase>generate-resources</phase>
            <goals>
              <goal>unpack</goal>
            </goals>
            <configuration>
              <artifactItems>
                <artifactItem>
                  <groupId>org.eclipse.jetty.toolchain.setuid</groupId>
                  <artifactId>jetty-setuid-native</artifactId>
                  <version>${project.version}</version>
                  <overWrite>true</overWrite>
                  <outputDirectory>${native-source-dir}/</outputDirectory>
                </artifactItem>
              </artifactItems>
            </configuration>
          </execution>
        </executions>
      </plugin>
      <plugin>
        <groupId>org.codehaus.mojo</groupId>
        <artifactId>native-maven-plugin</artifactId>
 ...
  </build>
  <dependencies>
    <dependency>
      <groupId>org.eclipse.jetty.toolchain</groupId>
      <artifactId>jetty-test-helper</artifactId>
      <version>${jetty-test-helper-version}</version>
      <scope>test</scope>
    </dependency>
    <dependency>
      <groupId>org.eclipse.jetty.toolchain.setuid</groupId>
      <artifactId>jetty-setuid-java</artifactId>
      <version>${project.version}</version>
-    </dependency>
-    <dependency>
-      <groupId>org.eclipse.jetty.toolchain.setuid</groupId>
-      <artifactId>jetty-setuid-native</artifactId>
-      <version>${project.version}</version>
    </dependency>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]