https://bugzilla.redhat.com/show_bug.cgi?id=1378014 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256: ff3642dfd8e9cf2b4196c273cffbb2ccd5b55287e671ec6dd6083e8084546b10). Ok. Summary verified from FDPass.pm. Ok. Description verified from FDPass.pm. Ok. License verified from COPYING. Ok. TODO: I believe the `coreutils' build-time dependency is not needed as the spec file does not call "make dist". TODO: Close standard input to the "perl Makefile.PL" command in order not to wait for interactive confirmation. All tests pass. Ok. $ rpmlint perl-IO-FDPass.spec ../SRPMS/perl-IO-FDPass-1.1-2.fc26.src.rpm ../RPMS/x86_64/perl-IO-FDPass-* perl-IO-FDPass.src: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni perl-IO-FDPass.x86_64: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni 3 packages and 1 specfiles checked; 0 errors, 2 warnings. TODO: Upper-case the "unix" word in the description text. $ rpm -q -lv -p ../RPMS/x86_64/perl-IO-FDPass-1.1-2.fc26.x86_64.rpm drwxr-xr-x 2 root root 0 Sep 22 14:22 /usr/lib64/perl5/vendor_perl/IO -rw-r--r-- 1 root root 4486 Jul 6 2015 /usr/lib64/perl5/vendor_perl/IO/FDPass.pm drwxr-xr-x 2 root root 0 Sep 22 14:22 /usr/lib64/perl5/vendor_perl/auto/IO drwxr-xr-x 2 root root 0 Sep 22 14:22 /usr/lib64/perl5/vendor_perl/auto/IO/FDPass -rwxr-xr-x 1 root root 11240 Sep 22 14:22 /usr/lib64/perl5/vendor_perl/auto/IO/FDPass/FDPass.so drwxr-xr-x 2 root root 0 Sep 22 14:22 /usr/share/doc/perl-IO-FDPass -rw-r--r-- 1 root root 806 Jul 6 2015 /usr/share/doc/perl-IO-FDPass/Changes -rw-r--r-- 1 root root 4630 Jul 6 2015 /usr/share/doc/perl-IO-FDPass/README drwxr-xr-x 2 root root 0 Sep 22 14:22 /usr/share/licenses/perl-IO-FDPass -rw-r--r-- 1 root root 62 Mar 29 2013 /usr/share/licenses/perl-IO-FDPass/COPYING -rw-r--r-- 1 root root 3068 Sep 22 14:22 /usr/share/man/man3/IO::FDPass.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-IO-FDPass-1.1-2.fc26.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libperl.so.5.24()(64bit) 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-IO-FDPass-1.1-2.fc26.x86_64.rpm | sort -f | uniq -c 1 perl(IO::FDPass) = 1.1 1 perl-IO-FDPass = 1.1-2.fc26 1 perl-IO-FDPass(x86-64) = 1.1-2.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-IO-FDPass-1.1-2.fc26.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=15750001). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx