[Bug 1370096] Review Request: rubygem-celluloid-essentials - Internally used tools, and superstructural dependencies of Celluloid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1370096



--- Comment #6 from Jun Aruga <jaruga@xxxxxxxxxx> ---
(In reply to Germano Massullo from comment #3)
> Let's talk first about tests, because I think it is the biggest part to deal
> with.
> If I am right, enabling tests will require all "development dependencies"
> you can see at [1]. Many of them are not available in Fedora repositories
> 
> [1]: https://rubygems.org/gems/celluloid-essentials/versions/0.20.5

I think enabling tests will not require all "development dependencies", as Vit
said.
We do not test about benchmark, coverage, static code analysis (rubocop and
etc). We also do not use Bundler for our test in check section.

We want to test the logic, because there is often our environment specified
issue.

We sometimes comment out a test case in the test suite with "sed" command, and
etc, when it needs a development dependency that is not available in Fedora.

There are some tricky but typical techniques to package RPM.

For reference, you can see "sed" command lines in check section.
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-sprockets.git/tree/rubygem-sprockets.spec
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-puma.git/tree/rubygem-puma.spec


If you want to see more sample spec files about rubygem-*, for example you can
search by below search query on Google, to find those.

```
"rubygem-*.git" sed site:pkgs.fedoraproject.org filetype:spec
```

I think the adding test logic in check section may be a hard process for you,
especially if you are first time to do it. But after you have experienced
several packages, you may be accustomed to do it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]