[Bug 1359914] Review Request: lollypop - Music player for GNOME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1359914

leigh scott <leigh123linux@xxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |leigh123linux@xxxxxxxxxxxxx
                   |                            |m



--- Comment #7 from leigh scott <leigh123linux@xxxxxxxxxxxxxx> ---
The scriptlets are wrong, use the full path.

see

https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#desktop-database


also there is no need for the %dir

change from

%dir %{_datadir}/%{name}
%{_datadir}/%{name}/%{name}.gresource


to

%{_datadir}/%{name}/

this way it owns the directory and everything in it


There is no need to require gstreamer1 as gstreamer1-plugins-base requires it

change from

Requires:       gstreamer1-plugins-base, gstreamer1

to

Requires:       gstreamer1-plugins-base

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]