[Bug 1346245] Review Request: resultsdb_frontend - Frontend for the ResultsDB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1346245



--- Comment #1 from Ben Rosser <rosser.bjr@xxxxxxxxx> ---
So, first pass looks relatively sane, except as per the newer Python guidelines
you should use the following macros in %build and %install:

%{__python2} setup.py build -> %py2_build
%{__python2} setup.py install --skip-build --root %{buildroot} -> %py2_install

(see https://fedoraproject.org/wiki/Packaging:Python).

It would also be good to use "python2-*" to refer to your Requires and
BuildRequires where possible.

Otherwise I didn't find any blockers, so if you can modernize the Python macros
I'll go ahead with a full review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]