https://bugzilla.redhat.com/show_bug.cgi?id=1366047 Tomas Mraz <tmraz@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tmraz@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |tmraz@xxxxxxxxxx Flags| |fedora-review? --- Comment #23 from Tomas Mraz <tmraz@xxxxxxxxxx> --- I'll review this package. My comments: Use ExclusiveArch instead of BuildArch and in general follow https://fedoraproject.org/wiki/Packaging:Guidelines?rd=PackagingGuidelines#Architecture_Support If the reason for building on just the architectures specified is that the other platforms do not have the hardware needed, then please at least add a comment about this fact to the spec. The build is nonstandard and does not apply RPM_OPT_FLAGS and LDFLAGS during the build which means that hardening and optimalization is not applied. This must be fixed too. %attr(0755,root,root) %{_libdir}/*.so - %attr is not applicable to symlink -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx