https://bugzilla.redhat.com/show_bug.cgi?id=1376035 --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> --- (In reply to Petr Šabata from comment #2) > (In reply to Parag AN(पराग) from comment #1) > > 1) Python packaging guidelines recommends usage of macros > > %{?python_provide:%python_provide python2-%{name}} > > %{?python_provide:%python_provide python3-%{name}} > > > > Can they be not used in this package spec? See > > https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file > > I had some mysterious issues with these in COPR, IIRC. > I don't know if it's still the case. afaics, current modulemd.spec and using the python_provide macros is giving same provides results on python2-modulemd and python3-modulemd subpackages > > > 2) I see version in setup.py as "0.1". I think this package should use > > version as 0.1 > > > > 3) tarball can be generated using "python setup.py sdist". As upstream not > > released yet any tarball, can modulemd-0.1.tar.gz be used here? Just add in > > comment how this tarball is generated. > > This is still a pre-release quality code. > > We can do some quick tweaks and do an official release if Miroslav wants > this in Fedora already. The specification is still evolving and we break > API every now and then, though... Whichever way is chosen can we have some steps added to generate the tarball to try to verify its checksum. > > 3) URL should be https://pagure.io/modulemd > > Yes, it should :) Submitted PR https://pagure.io/modulemd/pull-request/14 ;-) 4) One more thing as this package is python providing module let's name it according to https://fedoraproject.org/wiki/Packaging:Naming#Python_source_package_naming as python-modulemd. 5) %autosetup can be used instead "%setup -q" 6) Subpackage modlint is missing Requires: python3-modulemd -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx