https://bugzilla.redhat.com/show_bug.cgi?id=1372123 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- $ rpmlint pacmanager pacmanager.noarch: W: spelling-error Summary(en_US) multi -> mulch, mufti pacmanager.noarch: W: spelling-error %description -l en_US rsh -> rah, rs, sh pacmanager.noarch: W: spelling-error %description -l en_US automator -> automaton, automate, automatism pacmanager.noarch: W: spelling-error %description -l en_US mRemoteNG -> remoteness pacmanager.noarch: W: incoherent-version-in-changelog 4.5.5.7 ['4.5.5.7-2.fc24', '4.5.5.7-2'] pacmanager.noarch: E: standard-dir-owned-by-package /usr/share/man pacmanager.noarch: E: standard-dir-owned-by-package /usr/share/icons pacmanager.noarch: W: non-conffile-in-etc /etc/bash_completion.d/pacmanager pacmanager.noarch: E: standard-dir-owned-by-package /usr/share/man/man1 pacmanager.noarch: W: no-manual-page-for-binary pacmanager_from_putty pacmanager.noarch: W: no-manual-page-for-binary pacmanager_from_mcm 1 packages and 0 specfiles checked; 3 errors, 8 warnings. So, the biggest issue here is the overuse of globs in %files: %doc %{_mandir}/man1/%{name}* %{_datadir}/* %{_sysconfdir}/* %{_bindir}/* 1. MUST: %files need to get a little more specific here, and own only the stuff needed. I'd suggest: %files %doc README %license LICENSE %{_mandir}/man1/pacmanager* %{_datadir}/pacmanager/ %{_datadir}/applications/pacmanager.desktop %{_datadir}/icons/hicolor/*/apps/pacmanager.* %{_sysconfdir}/bash_completion.d/pacmanager %{_bindir}/pacmanager* that should address most of the important rpmlint issues wrt %files pkg naming: ok license: ok macros: ok scriptlets: ok sources: ok 2e27507401adc2d7d9a7631d79a7a45f pac-4.5.5.7-all.tar.gz 2. MUST include .desktop file validation, see: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#desktop-file-install_usage either use desktop-file-install to install it (instead of manual copy), or do a desktop-file-validate in %check section. 3. MUST app icons. I see one of the icons you use/install is jpg. that type is not supported for icon themes, see also: https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#definitions Either omit that one, or convert it to png. 4. bash completion files SHOULD go under /usr/share/bash-completion/completions ie, BuildRequires: pkgconfig(bash-completion) and install/use the output from pkg-config --variable=completionsdir bash-completion (we can fix this collaboratively after review, if this is in anyway unclear) Please fix the 3 MUST items, and we should have a winner -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx