https://bugzilla.redhat.com/show_bug.cgi?id=1375926 --- Comment #1 from Neal Gompa <ngompa13@xxxxxxxxx> --- Overall, this spec looks good. It conforms very well to the Fedora guidelines. However, there are a couple of issues. For example, if this package is intended to work with EPEL, you need to support the EPEL bootstrap case in the spec. You can see my python-pika package as an example: http://pkgs.fedoraproject.org/cgit/rpms/python-pika.git/tree/python-pika.spec The information about this is under EPEL Python 3 packaging draft: https://fedoraproject.org/wiki/User:Bkabrda/EPEL7_Python3 The other issue is rather minor, and it's that %defattr() is being used in the file lists when it's unnecessary (it's setting it to the default value RPM does already). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx