https://bugzilla.redhat.com/show_bug.cgi?id=1270622 --- Comment #6 from Michal Ambroz <rebus@xxxxxxxxx> --- Hi Igor, thanks for additional review. SPEC: https://rebus.fedorapeople.org/SPECS/sdb.spec SRPM: https://rebus.fedorapeople.org/SRPMS/sdb-0.10.5-3.bf6575a.fc23.src.rpm Fixed: >* Missing BuildRequires: gcc >* vapi files should go under devel subpackage >* Redundant BuildRequires: vala-devel (should be just vala) >* Tests are not ran >* BR: leveldb-devel is not needed unless you run tests I Will check: >* LDFLAGS are ignored >* BR: nodejs-devel is not needed as you don't package nodejs lib from tree >* %make_build and %make_install are preferred way not mandatory and not preffered by me Will check and report upstream (I have to change): >* Timestamps are not preserved >* Group tag is redundant it is not prohibited and needed to epel Best regards Michal Abroz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx