https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #25 from yunying.sun@xxxxxxxxx --- (In reply to Dmitrij S. Kryzhevich from comment #24) > I meant this: > > $ md5sum tpm2-tss-1.0.tar.gz 1.0-beta_1.tar.gz > 2cdda79640f1e2e534ff897480190686 tpm2-tss-1.0.tar.gz > 3d6df831cee731d95ef754f6599b3a6c 1.0-beta_1.tar.gz > > tpm2-tss-1.0.tar.gz was gotten from prev src.rpm. > Now that's OK (anyway, diff see no changes in sources but still was a > blocker). In previous SRPM, I downloaded source tarball from upstream, uncompressed, then change folder name manually(TPM2.0-TSS-1.0-beta_1.tar.gz -> tpm2-tss-1.0.tar.gz) and compress it again. Without manually name change, rpm failed to find the package with name %{name}-%{version}.tar.gz. > > Little issue: I see tabs and spaces in spec. I's better use one style. Corrected. > > And please refer documentation you used to mark license for sapi headers. > That is not an issue from me, I just don't know whether it could be marked > as BSD or not. Confirmed with upstream that BSD would be OK as well for sapi headers. > > You used %autosetup so no epel6 builds, right? We are trying to add this package for rawhide(latest Fedora development version) first, so EPEL7 is enough. Updated SPEC & SRPM: SPEC: https://raw.githubusercontent.com/yunyings/share/master/tpm2-tss.spec SRPMS: https://github.com/yunyings/share/raw/master/tpm2-tss-1.0-0.1.beta1.el7.src.rpm COPR build: https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tss/build/452011/ @Dmitrij, please help to review again. Really appreciate. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx