https://bugzilla.redhat.com/show_bug.cgi?id=1270622 --- Comment #4 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- Few notes here: * LDFLAGS are ignored * Missing BuildRequires: gcc * Redundant BuildRequires: vala-devel (should be just vala) * %make_build and %make_install are preferred way * Group tag is redundant * vapi files should go under devel subpackage * Tests are not ran * BR: nodejs-devel is not needed as you don't package nodejs lib from tree * BR: leveldb-devel is not needed unless you run tests * Timestamps are not preserved Probably there are more issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx