https://bugzilla.redhat.com/show_bug.cgi?id=1368790 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #12 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Looks good overall but do these changes before importing this package in Fedora. 1) we need to add comment to every patch just above its added in specfile and give few words reason why this package need to be patched or if this patch is already upstream then add upstream tracker url in comment 2) The following explicit Requires: line is not needed as this package already generates actual Requires, so remove it Requires: perl(PFT) See this $rpm -qp --requires perl-App-PFT-1.0.6-1.fc25.noarch.rpm |grep PFT perl(App::PFT) perl(App::PFT::Util) perl(PFT::Conf) perl(PFT::Date) perl(PFT::Header) perl(PFT::Text) perl(PFT::Tree) perl(PFT::Util) APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx