[Bug 1374024] Review Request: plotcat - plotcat is the python library for plotting live serial input using matplotlib.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1374024



--- Comment #4 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Issues:
=======
1) Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: plotcat.spec should be python-plotcat.spec
  See:
  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name


2) Rpmlint
-------
Checking: python2-plotcat-1.0.0-2.fc26.noarch.rpm
          python3-plotcat-1.0.0-2.fc26.noarch.rpm
          python-plotcat-1.0.0-2.fc26.src.rpm
python2-plotcat.noarch: W: summary-not-capitalized C tool to plot live serial
input

==> Start with a capital letter

python2-plotcat.noarch: W: invalid-license GPL v3
==> The valid license tag is "GPLv3", see
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses

python2-plotcat.noarch: W: no-documentation
==> This is okay as there really is no documentation files available in source
tarball.

python2-plotcat.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/plotcat/__init__.py /usr/bin/env python
python2-plotcat.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/plotcat/__init__.py 644 /usr/bin/env python
python2-plotcat.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/plotcat/plotcat.py /usr/bin/env python
python2-plotcat.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/plotcat/plotcat.py 644 /usr/bin/env python
==> You can fix this in %prep section as
sed -i -e '/^#!\//, 1d' *.py

python2-plotcat.noarch: W: no-manual-page-for-binary live_plot.py-2
python2-plotcat.noarch: W: no-manual-page-for-binary live_plot.py
python2-plotcat.noarch: W: no-manual-page-for-binary live_plot.py-2.7
==> This is okay as there is no man page provided in source tarball

3) Add some detailed description about your package. Just see the text you have
in README.md

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]