https://bugzilla.redhat.com/show_bug.cgi?id=1373243 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Test-Filename.spec.old 2016-09-05 16:36:19.000000000 +0200 +++ perl-Test-Filename.spec 2016-09-06 09:59:51.000000000 +0200 @@ -1,6 +1,6 @@ Name: perl-Test-Filename Version: 0.03 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Portable filename comparison License: ASL 2.0 @@ -9,13 +9,16 @@ BuildArch: noarch BuildRequires: make +BuildRequires: findutils BuildRequires: perl BuildRequires: perl-generators BuildRequires: perl(English) -BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30 +BuildRequires: perl(File::Find) BuildRequires: perl(File::Spec::Functions) BuildRequires: perl(File::Temp) BuildRequires: perl(Path::Tiny) +BuildRequires: perl(strict) BuildRequires: perl(Test::Builder::Module) BuildRequires: perl(Test::More) BuildRequires: perl(Test::Tester) @@ -48,12 +51,17 @@ %files -%doc Changes README +%doc Changes README Todo examples %license LICENSE %{perl_vendorlib}/* %{_mandir}/man3/Test::Filename*.* %changelog +* Tue Sep 06 2016 Sandro Mani <manisandro@xxxxxxxxx> - 0.03-2 +- BR: findutils, perl(File::Find), perl(strict) +- BR: perl(ExtUtils::MakeMaker) >= 6.30 +- Add to %%doc: Todo, examples + * Mon Sep 05 2016 Sandro Mani <manisandro@xxxxxxxxx> - 0.03-1 - Initial package > TODO: Package `Todo' file and `examples' directory as documentation. -%doc Changes README +%doc Changes README Todo examples Ok. > TODO: Constrain `perl(ExtUtils::MakeMaker)' dependency with `>= 6.30' > (Makefile.PL:7). -BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30 Ok. > FIX: Build-require `findutils' (perl-Test-Filename.spec:43). +BuildRequires: findutils Ok. > FIX: Build-require `perl(strict)' (Makefile.PL:2). +BuildRequires: perl(strict) Ok. > FIX: Build-require `perl(File::Find)' (t/00-compile.t:10). +BuildRequires: perl(File::Find) Ok. $ rpmlint perl-Test-Filename.spec ../SRPMS/perl-Test-Filename-0.03-2.fc26.src.rpm ../RPMS/noarch/perl-Test-Filename-0.03-2.fc26.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. Package builds in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=15515888). Ok. Package is good. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx