https://bugzilla.redhat.com/show_bug.cgi?id=1373243 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256: 6a450cc4c6281ed1129f32a1c0741f228967feda2e32a2915ff621c36525fcbe). Ok. Summary verified from lib/Test/Filename.pm. Ok. Description verified from lib/Test/Filename.pm. Ok. License verified from README, LICENSE, and lib/Test/Filename.pm. Ok. No XS code, noarch BuildArch is Ok. TODO: Package `Todo' file and `examples' directory as documentation. TODO: Constrain `perl(ExtUtils::MakeMaker)' dependency with `>= 6.30' (Makefile.PL:7). FIX: Build-require `findutils' (perl-Test-Filename.spec:43). FIX: Build-require `perl(strict)' (Makefile.PL:2). FIX: Build-require `perl(File::Find)' (t/00-compile.t:10). All tests pass. Ok. $ rpmlint perl-Test-Filename.spec ../SRPMS/perl-Test-Filename-0.03-1.fc26.src.rpm ../RPMS/noarch/perl-Test-Filename-0.03-1.fc26.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Test-Filename-0.03-1.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Sep 6 08:46 /usr/share/doc/perl-Test-Filename -rw-r--r-- 1 root root 465 Jan 31 2013 /usr/share/doc/perl-Test-Filename/Changes -rw-r--r-- 1 root root 2806 Jan 31 2013 /usr/share/doc/perl-Test-Filename/README drwxr-xr-x 2 root root 0 Sep 6 08:46 /usr/share/licenses/perl-Test-Filename -rw-r--r-- 1 root root 11503 Jan 31 2013 /usr/share/licenses/perl-Test-Filename/LICENSE -r--r--r-- 1 root root 2450 Sep 6 08:46 /usr/share/man/man3/Test::Filename.3pm.gz drwxr-xr-x 2 root root 0 Sep 6 08:46 /usr/share/perl5/vendor_perl/Test -r--r--r-- 1 root root 3667 Jan 31 2013 /usr/share/perl5/vendor_perl/Test/Filename.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Test-Filename-0.03-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(:VERSION) >= 5.6.0 1 perl(Path::Tiny) 1 perl(strict) 1 perl(Test::Builder::Module) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Test-Filename-0.03-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(Test::Filename) = 0.03 1 perl-Test-Filename = 0.03-1.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Test-Filename-0.03-1.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=15513386). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide a new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx