https://bugzilla.redhat.com/show_bug.cgi?id=1327635 Javier Peña <jpena@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jpena@xxxxxxxxxx) | --- Comment #10 from Javier Peña <jpena@xxxxxxxxxx> --- Hi Marcos, fedora-review (see report below) is complaining about a couple items: - We need to add some Requires for the systemd commands we include in %post and other sections, you can use https://github.com/openstack-packages/openstack-example-spec/blob/master/openstack-example.spec#L30-L33 as an example - There is a pulp-rpm requirement, which I guess is coming from the usage of a library called PuLP (https://pypi.python.org/pypi/PuLP/1.6.1). I haven't found a package for this, we need to package it. - Also, I see the spec uses the Mitaka congress version, we should update it to the Newton one (after we get PuLP packaged). --------------------------------------------------------------------- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Binary eggs must be removed in %prep Note: Binary egg files not removed in %prep: ./thirdparty/antlr3-antlr-3.5/runtime/Python/dist/antlr_python_runtime-3.4-py2.4.egg ./thirdparty/antlr3-antlr-3.5/runtime/Python/dist/antlr_python_runtime-3.4-py2.6.egg See: http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "BSD (3 clause)", "MIT/X11 (BSD like)", "Unknown or generated", "*No copyright* Apache (v2.0)". 542 files have unknown license. Detailed output of licensecheck in /tmp/congress /review-openstack-congress/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/system, /etc/logrotate.d, /usr/lib/systemd [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- congress , python-congress-doc [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.20 starting (python version = 3.5.1)... Start: init plugins INFO: tmpfs initialized INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: mounting tmpfs at /var/lib/mock/dlrn-centos7-x86_64/root. INFO: reusing tmpfs at /var/lib/mock/dlrn-centos7-x86_64/root. INFO: calling preinit hooks INFO: enabled root cache INFO: enabled yum cache Start: cleaning yum metadata Finish: cleaning yum metadata Mock Version: 1.2.20 INFO: Mock Version: 1.2.20 Finish: chroot init INFO: installing package(s): /tmp/congress/review-openstack-congress/results/python-congress-3.0.0-1.el7.centos.noarch.rpm /tmp/congress/review-openstack-congress/results/python-congress-doc-3.0.0-1.el7.centos.noarch.rpm /tmp/congress/review-openstack-congress/results/openstack-congress-3.0.0-1.el7.centos.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/yum-deprecated --installroot /var/lib/mock/dlrn-centos7-x86_64/root/ --releasever 7 install /tmp/congress/review-openstack-congress/results/python-congress-3.0.0-1.el7.centos.noarch.rpm /tmp/congress/review-openstack-congress/results/python-congress-doc-3.0.0-1.el7.centos.noarch.rpm /tmp/congress/review-openstack-congress/results/openstack-congress-3.0.0-1.el7.centos.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: openstack-congress-3.0.0-1.el7.centos.noarch.rpm python-congress-3.0.0-1.el7.centos.noarch.rpm python-congress-doc-3.0.0-1.el7.centos.noarch.rpm openstack-congress-3.0.0-1.el7.centos.src.rpm openstack-congress.noarch: W: incoherent-version-in-changelog 3.0.0-1 ['3.0.0-1.el7.centos', '3.0.0-1.centos'] openstack-congress.noarch: W: no-documentation openstack-congress.noarch: W: non-standard-gid /etc/congress/api-paste.ini congress openstack-congress.noarch: W: non-conffile-in-etc /etc/congress/api-paste.ini openstack-congress.noarch: W: non-standard-uid /var/log/congress congress openstack-congress.noarch: W: non-standard-gid /var/log/congress congress openstack-congress.noarch: E: non-standard-dir-perm /var/log/congress 750 openstack-congress.noarch: W: non-standard-gid /etc/congress congress openstack-congress.noarch: E: non-standard-dir-perm /etc/congress 750 openstack-congress.noarch: W: non-standard-gid /etc/congress/congress.conf congress openstack-congress.noarch: W: non-conffile-in-etc /etc/congress/congress.conf openstack-congress.noarch: W: non-standard-gid /etc/congress/policy.json congress openstack-congress.noarch: W: non-conffile-in-etc /etc/congress/policy.json openstack-congress.noarch: W: no-manual-page-for-binary congress-server openstack-congress.noarch: W: no-manual-page-for-binary congress-db-manage python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/server/congress_server.py 644 /usr/bin/python python-congress.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/congress/datasources/neutronv2_driver.py /usr/bin/env python python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/datasources/neutronv2_driver.py 644 /usr/bin/env python python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/tests/datalog/builtin/test_builtin.py 644 /usr/bin/python python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/datalog/builtin/congressbuiltin.py 644 /usr/bin/python python-congress.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/congress/datasources/cloudfoundryv2_driver.py /usr/bin/env python python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/datasources/cloudfoundryv2_driver.py 644 /usr/bin/env python 4 packages and 0 specfiles checked; 9 errors, 13 warnings. Requires -------- openstack-congress (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 config(openstack-congress) python-congress python-congress-doc python-congress (rpmlib, GLIBC filtered): pulp-rpm python(abi) python-alembic python-babel python-dateutil python-eventlet python-paste python-paste-deploy python-pbr python-routes python-six python-swiftclient python-webob python2-ceilometerclient python2-cinderclient python2-glanceclient python2-heatclient python2-keystoneclient python2-keystonemiddleware python2-muranoclient python2-neutronclient python2-novaclient python2-oslo-config python2-oslo-context python2-oslo-db python2-oslo-log python2-oslo-messaging python2-oslo-middleware python2-oslo-policy python2-oslo-serialization python2-oslo-service python2-oslo-utils python2-oslo-vmware python-congress-doc (rpmlib, GLIBC filtered): Provides -------- openstack-congress: config(openstack-congress) openstack-congress python-congress: python-congress python-congress-doc: python-congress-doc Source checksums ---------------- http://tarballs.openstack.org/congress/congress-3.0.0.tar.gz : CHECKSUM(SHA256) this package : 24225ac169f55a400f127fb0eb0e9bfa0846198f4a4d965cd81b3883a29fb4d2 CHECKSUM(SHA256) upstream package : 24225ac169f55a400f127fb0eb0e9bfa0846198f4a4d965cd81b3883a29fb4d2 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -n openstack-congress -m dlrn Buildroot used: dlrn-centos7-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx