https://bugzilla.redhat.com/show_bug.cgi?id=1359412 David Kaspar [Dee'Kej] <dkaspar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo? --- Comment #3 from David Kaspar [Dee'Kej] <dkaspar@xxxxxxxxxx> --- Another set of notes about the package: 20) Since this package provides a library and other packages might be linking to it, is there a reason why this software is not packaged under some LGPL license? Legal stuff is generally problematic, this is just a question. 21) I see the m4/ folder inside the source package. Are you using automate (autoconf) for anything? Because if you do, you probably need additional BuildRequires for 'autoconf'... 23) Looking at the content of README file - it describes the use of libgawkextlib. This is suitable for the %description devel section. And the notes on how to build package from git sources are considered irrelevant. IOW: * lets drop README file * move the first section of it into %description devel * ignore the info about building from git-sources 24) Do you have any documentation for the library, for example in some markdown format? If so, it would be good to add it into the sourceball, because after it we could transform the markdown into man page... :) Feel free to reach to me, if you need any help. ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx