https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #17 from yunying.sun@xxxxxxxxx --- (In reply to yunying.sun from comment #16) > (In reply to Ralf Corsepius from comment #13) > > (In reply to yunying.sun from comment #12) > > > Could you help to review again? > > > > Here we go: > > > > - Please append --disable-silent-rules to %configure > > This enforces verbose building, because silent building is not helpful when > > building packages in batches. > > > > - Please disable-static libs. > > Static libs are strongly discouraged in Fedora. > > > > To achieve this, append --disable-static to %configure > > and remove %{_libdir}/*.a from %files > > > @Ralf, after disabling static library build, the other package tpm2-tools > local rpm build fails due to not finding SAPI. Reason is that it depens on > libsapi.a & libtcti-*.a which ought to be generated from tpm2-tss build. > > What is the right way to solve this issue? > > On wiki: > https://fedoraproject.org/wiki/Packaging: > Guidelines#Packaging_Static_Libraries, one solution is put static libs into > a *-static subpackage, and use "BuildRequires: *-static" for packages which > links to this static subpackage. > > Is this the right way to go? > Sorry, false alarm. I forgot to install tpm2-tss(devel).rpm before doing rpm local build.. Please ignore the problem in comment #16. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx