[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1372866

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx



--- Comment #8 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
MUSTFIXES:

- Package does not honor RPM_OPT_FLAGS:
Your spec appends Fedora incompatible compilation flags to CFLAGS/CXXFLAGS.

Remove these 2 lines from your spec:
export CFLAGS="$RPM_OPT_FLAGS -march=core2"
export CXXFLAGS="${CFLAGS}"

- Directory /usr/include/hs/ is unowned.
Add this directory to *-devel's %files

- Package ships static libs. 
This is strongly discouraged in Fedora. Please disable building static libs
unless there are very strong reasons to ship them.

- The base package contains files which should be packaged in *-devel, instead
of the base package.
%{_libdir}/*.so should go into devel,
%{_libdir}/*.so.* into <base>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]