https://bugzilla.redhat.com/show_bug.cgi?id=1367976 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Mamoru TASAKA from comment #3) > Thank you for initial comments! I said I approve the package but forgot to set review+, sorry ... > * Integration test suite > - Well, there is "rspec spec/" in spec file, do you mean other > test suite here? > > * > you keep around the test suite (features folder) > - Well, I think "features" directory explains the "feature" of this > gem, i.e. quite similar with "examples". > For example, "features/basics/simple_example.feature" explains the > basic usage of this gem. Actually, these two bullets are more or less one bullet then, since the features directory contains the test suite in question if I am not mistaken. That should be executable using Cucumber. In theory, calling "cucumber" command should be enough to execute it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx