[Bug 1367976] Review Request: rubygem-contracts - Contracts for Ruby

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1367976



--- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
Generally, the package looks ok => I APPROVE the package.


Nevertheless, there are few nits I'd like to clarify:

* Integration test suite
  - Have you tried to execute the integration test suite?

* Keeping the integration test suite around
  - You remove quite a lot of stuff from the package, including the test suite.
    Nevertheless, you keep around the test suite (features folder). I am
    wondering what is the reason for this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]