[Bug 1372454] Review Request: bwrap-oci - run OCI containers with bubblewrap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1372454

Igor Gnatenko <ignatenko@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |ignatenko@xxxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #1 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
1. Spec is not downloadable
2. SourceURL is unreachable

> %global commit0 06ed9c9054db435ae33f0c917a2d5e7d3e40e6fa
drop this, as you don't build from commit

> Source0: https://github.com/projectatomic/%{name}/archive/%{name}-%{version}.tar.gz
%global rel 3
Source0: %{url}/archive/%{name}-%{version}-%{rel}.tar.gz

> BuildRequires: git
not really

> BuildRequires: docbook-style-xsl
looks like you don't need it

> BuildRequires: libxslt
looks like you don't need it

> BuildRequires: json-glib-devel
BuildRequires: pkgconfig(json-glib-1.0)

> %autosetup -Sgit -n %{name}-%{version}
%autosetup -n %{name}-%{name}-%{version}-%{rel}

> make %{?_smp_mflags}
%make_build

> make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p -c"
%make_install INSTALL="install -p"

> find $RPM_BUILD_ROOT -name '*.la' -delete
not needed, you don't have any libtool files

> %{_mandir}/man1/*
%%{_mandir}/man1/%{name}.1*

> %{_bindir}/bwrap-oci
%{_bindir}/%{name}

* Missing BuildRequires: gcc
* Missing BuildRequires: pkgconfig(gio-unix-2.0)
* My recommendation - stop using tito ASAP, otherwise you will stick to it and
always will have to do double work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]