https://bugzilla.redhat.com/show_bug.cgi?id=1372345 --- Comment #3 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- (In reply to José Matos from comment #2) > (In reply to Igor Gnatenko from comment #1) > > I will review it today/tomorrow. > > Thank you. :-) > > > Initial comments: > > > > > BuildRequires: python-setuptools > > BuildRequires: python2-setuptools > > Right, I used pyp2rpm to generate the first version and this detail was lost > in the revision. I will fix it in the next revision. > > > > %{python2_sitelib}/%{pypi_name} > > %{python2_sitelib}/%{pypi_name}/ > > Why do we need the trailing slash? distutils creates file .egg-info, but setuptools creates directory .egg-info. As you have BR: setuptools it's better to be sure that it's used ;) > > IIRC in %files > > mydir > > is the same as > > %dir mydir > mydir/* > > I admit that my memory could be failing. :-) > > > > %{python2_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info > > %{python2_sitelib}/%{pypi_name}-*.egg-info/ > > or > > %{python2_sitelib}/%{pypi_name}-%{version}-py%{python2_version}.egg-info/ > > (note trailing slash) > > > > .. same for python3 > > I will change to the * version or else it will fail at python 3.10. :-) No, it will not ;) it's not regex, it's glob. * takes any numbers of any characters. > > > * I think it has missing Requires: pythonX-pillow > > No it does not. I looked into the code, it mainly imports struct and io that > are in the standard library. > > It is supposed to work with pillow and thus the tests but it does not > require it. Ah, okay. > > > * Don't duplicate %description, define it just once > > I saw a tip from you recently but I forgot it. How do you suggest to have a > single description? %global _description \ foo\ bar. %description %{_description} %description -n python2-%{modname} %{_description} Python 2 version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx