https://bugzilla.redhat.com/show_bug.cgi?id=1372345 Igor Gnatenko <ignatenko@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |ignatenko@xxxxxxxxxx --- Comment #1 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- I will review it today/tomorrow. Initial comments: > BuildRequires: python-setuptools BuildRequires: python2-setuptools > %{python2_sitelib}/%{pypi_name} %{python2_sitelib}/%{pypi_name}/ > %{python2_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info %{python2_sitelib}/%{pypi_name}-*.egg-info/ or %{python2_sitelib}/%{pypi_name}-%{version}-py%{python2_version}.egg-info/ (note trailing slash) .. same for python3 * I think it has missing Requires: pythonX-pillow * I would not put tests out of tree, as if something changes on github you will not notice. * I would just build from git tag (and write comment that this commit is actually version X.Y.Z) - https://github.com/hMatoba/Piexif/issues/23 * Don't duplicate %description, define it just once * Move BuildRequires under subpackages for better look&feel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx