https://bugzilla.redhat.com/show_bug.cgi?id=1358215 --- Comment #6 from Jan Chaloupka <jchaloup@xxxxxxxxxx> --- >> Would be handy to at least: >> >> %global provider github >> %global provider_tld com >> %global project direnv >> %global repo direnv >> # https://github.com/direnv/direnv >> %global provider_prefix %{provider}.%{provider_tld}/%{project}/%{repo} >> %global import_path %{provider_prefix} >> %global commit 2bb2df4ca3bf3f45d1f36372c279615239e5c0f4 >> >> The commit is important so automatic tooling can scan your spec file and >> connect the code with commit and repository. > Can you elaborate on this please? The spec file doesn't built a particular > upstream commit, it only uses official releases, so I'm not sure that > hardcoding SHAs into the spec file makes sense. The release itself is important for rpm's NVR. It is easier to search for commit macro in the spec file rather then parsing package release version and then detecting the corresponding commit from it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx