[Bug 1247243] Review Request: mod_cluster - httpd modules and Tomcat/ WildFly java libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1247243



--- Comment #29 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Michal Karm Babacek from comment #28)
> Hi Gil, thank you for the file, it's so much cleaner with the pom macros.
> 
> I used it almost without changes, but my local, scratch and smoke test
> failed, so I did several additional changes. I hope they are cool.
> 
> Current state: https://github.com/Karm/mod_cluster-fedora-packages/
> 
> Summary of changes:
> 
>  - removed buildarch due to: RPM build errors: Arch dependent binaries in
> noarch package


"BuildArch:        noarch" must be aded on in the java* packages
(sorry, i wrote a clean new spec and i forgotten to remove it in the main
package, my custom spec file template ...)

e.g.

%if %{without java}
%package java
Summary:          Java libraries for %{name}
BuildArch:        noarch

%description java
This package contains %{name} core Java libraries
that can be used with WildFly application server. 

%package java-tomcat8
Summary:          Tomcat 8 Java libraries for %{name}
Requires:         tomcat >= 1:8
BuildArch:        noarch

%description java-tomcat8
This package contains %{name} Java libraries that can be used with Tomcat 8.

%package javadoc
Summary:          Javadoc for %{name}
BuildArch:        noarch

%description javadoc
This package contains the API documentation for %{name}.
%endif



>  - we need tomcat-lib for build, so I added mvn(..) macros that lead to
> tomcat-lib dependency rather than directly requiring tomcat just for build

%if %{without java}
BuildRequires: maven-local
BuildRequires: mvn(net.jcip:jcip-annotations)
BuildRequires: mvn(org.apache.maven.plugins:maven-enforcer-plugin)
BuildRequires: mvn(org.apache.tomcat:tomcat-catalina)
BuildRequires: mvn(org.apache.tomcat:tomcat-coyote)
BuildRequires: mvn(org.apache.tomcat:tomcat-util)
BuildRequires: mvn(org.jboss:jboss-parent:pom:)
BuildRequires: mvn(org.jboss.logging:jboss-logging)
BuildRequires: mvn(org.jboss.logging:jboss-logging-processor)
BuildRequires: mvn(org.jboss.spec.javax.servlet:jboss-servlet-api_3.0_spec)
%endif

you shold use "BuildRequires: mvn(org.jboss.logging:jboss-logging-processor)"
in the pom files is specified this artifact.
not BuildRequires: mvn(org.jboss.logging:jboss-logging-processor:pom:)


Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15431065

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]