Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pv - A tool for monitoring the progress of data through a pipeline https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245515 ------- Additional Comments From kevin@xxxxxxxxx 2007-07-06 16:10 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (Artistic) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: a26e523e54c511ed8d263f16a7025330 pv-0.9.9.tar.gz a26e523e54c511ed8d263f16a7025330 pv-0.9.9.tar.gz.1 See below - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Not a blocker, but I see that the during the build the install attempts to install a pv.info file, which doesn't exist. Might ask upstream about either including that or removing the code which refers to it. /usr/bin/install -c -m 644 doc/pv.info \ "/var/tmp/pv-0.9.9-1.fc8-c16338//usr/share/info/pv.info" /usr/bin/install: cannot stat `doc/pv.info': No such file or directory make: [install] Error 1 (ignored) 2. Also, it looks like 'man' is called during build: man doc/quickref.1 | sed 's/.^H//g' | cat -s > doc/quickref.txt || : /bin/sh: man: command not found Should there be a BuildRequires: man ? I suppose only if you wanted to package the quickref.txt file? That file seems to be a copy of the man page... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review