https://bugzilla.redhat.com/show_bug.cgi?id=1357064 --- Comment #24 from Raphael Groner <projects.rg@xxxxxxxx> --- (In reply to Neal Gompa from comment #22) > Couple of issues I noticed: > > * update-desktop-database scriptlets need to be guarded out so they don't > run on F25+: > https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging: > ScriptletSnippets#desktop-database As far as I understand the fpc ticket [1], it does not harm to keep the scriptlets. Test builds still work. [1] https://fedorahosted.org/fpc/ticket/636 > * Suggests are not helpful. There's no way to discover or install Suggests > from DNF or PackageKit, so I would suggest making a metapackage > (lumina-desktop-environment, maybe?) that pulls in everything, or upgrading > the relationship from Suggests to Recommends. The former is more useful if > you plan to also offer this in EPEL, too. What does that have to do with the review? Please open another bug when the package will be imported into Fedora. You are properly looking for a comps. (In reply to Neal Gompa from comment #23) > Also, > > You will need to configure libLumina for Fedora by introducing a Fedora.cpp > file with the appropriate configuration and adjust the build scripts to use > it in place of generic Linux.cpp. It might be worth upstreaming it as well. > > See: https://github.com/trueos/lumina/tree/master/src-qt5/core/libLumina Project MESSAGE: Build OS Info: Linux, x86_64, #1 SMP Thu May 19 13:05:32 UTC 2016 Project MESSAGE: Build Settings Loaded: Linux - What's the issue with that? Build works. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx