https://bugzilla.redhat.com/show_bug.cgi?id=1366355 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #21 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- New packages cannot be added for Fedora 22, so the check '%if 0%{?fedora} > 22' can be simplified to '%if 0%{?fedora}'. + package name is OK + license is acceptable (MIT) + license is specified correctly + latest version + provides/requires/buildrequires are specified correctly + package builds and installs OK + rpmlint is OK (see below) + scriptlets look sane rpmlint: acme-tiny.noarch: W: spelling-error Summary(en_US) Auditable -> Audi table, Audi-table, Audit able acme-tiny.noarch: W: spelling-error %description -l en_US auditable -> audit able, audit-able, editable "auditable" is a neologism, but OK. acme-tiny.noarch: W: incoherent-version-in-changelog 0.1-9 ['0.1-9.git5a7b4e7.fc24', '0.1-9.git5a7b4e7'] Please make sure this is OK when the package is built. acme-tiny.noarch: W: non-standard-uid /var/lib/acme/private acme acme-tiny.noarch: W: non-standard-gid /var/lib/acme/private acme acme-tiny.noarch: E: non-standard-dir-perm /var/lib/acme/private 700 acme-tiny.noarch: W: non-standard-uid /var/www/challenges acme acme-tiny.noarch: W: non-standard-gid /var/www/challenges acme acme-tiny.noarch: W: non-standard-uid /var/lib/acme/lets-encrypt-x3-cross-signed.pem acme acme-tiny.noarch: W: non-standard-gid /var/lib/acme/lets-encrypt-x3-cross-signed.pem acme acme-tiny.noarch: W: pem-certificate /var/lib/acme/lets-encrypt-x3-cross-signed.pem acme-tiny.noarch: W: non-standard-uid /var/lib/acme/csr acme acme-tiny.noarch: W: non-standard-gid /var/lib/acme/csr acme acme-tiny.noarch: W: non-standard-uid /var/lib/acme acme acme-tiny.noarch: W: non-standard-gid /var/lib/acme acme acme-tiny.noarch: W: non-standard-uid /var/lib/acme/certs acme acme-tiny.noarch: W: non-standard-gid /var/lib/acme/certs acme Those are OK. acme-tiny.noarch: W: no-manual-page-for-binary acme_tiny acme-tiny.noarch: W: no-manual-page-for-binary acme-tiny-sign acme-tiny.noarch: W: no-manual-page-for-binary acme-tiny acme-tiny.noarch: W: no-manual-page-for-binary cert-check Not needed, docs are provided in READMEs. 1 packages and 0 specfiles checked; 1 errors, 20 warnings. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx