[Bug 1366687] Review Request: gnutls30 - A TLS protocol implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1366687

Jan Včelák <jv+fedora@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(nmavrogi@redhat.c
                   |                            |om)



--- Comment #6 from Jan Včelák <jv+fedora@xxxxxxxxx> ---
Thank you, Nikos. Please, can you take a look at the updated package. I believe
I've resolved all the issues.

> - Provides: bundled(gnulib) in place as required.
>   Note: Bundled gnulib but no Provides: bundled(gnulib)

Fixed.

> - ldconfig called in %post and %postun if required.

Fixed. (I always forget.)

> - License text is not installed with %doc or %license

Fixed. COPYING.LESSER is included in the main package.

> - License in spec does not match the actual license (LGPLv2+ - missing '+')

Fixed. Good catch.

> - Package bundles libtasn1

I think that bundling libtasn1 can be justified in this case based on the
result of quick discussion in #epel and by investigating existing packages in
the repository.

There is currently no other package that would require recent version of
libtasn1. Having a separate forward compatibility package would just increase
the maintenance burden with no benefit.

I've added bundled(libtasn1) Provides so this can be eventually tracked.

> - gnutls30-devel conflicts with gnutls-devel

Fixed.

The headers are now located in /usr/include/gnutls30/gnutls, unversioned
libraries are in /usr/libXX/gnutls30, and pkg-config files were modified
appropriately. I've also included simple README.fedora describing what has to
be done to compile against gnutls30-devel instead of gnutls-devel.

I've tested that the packages can be co-installed with gnutls-devel and that
building to the individual versions of the library is possible just by setting
the pkg-config search paths.

In addition, I've eliminated rpath on libgnutls-dane and libgnutlsxx.

Updated SPEC:
https://jvcelak.fedorapeople.org/review/gnutls30/3.5.3-3/gnutls30.spec

Updated SRPM:
https://jvcelak.fedorapeople.org/review/gnutls30/gnutls30-3.5.3-3.el6.src.rpm

Binary build:
https://copr.fedorainfracloud.org/coprs/jvcelak/gnutls30/build/445951/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]