Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtextcat - language guessing library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245917 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-07-06 12:16 EST ------- I'll assume that the libtool build dependency is there for the purposes of this review. rpmlint says: W: libtextcat-devel no-documentation which is OK. This package screws with the compiler flags as noted above. Frankly I don't know what gcc does when it sees -O3 -O2 on the command line, but I'll trust Ralf's assessment above that it doesn't cause problems. Since you're running the autotools anyway, it should be easy to patch them out but I don't think it's mandatory. So I'll approve this, but of course you'll have to add the libtool dependency so that you can build. Review: * source files match upstream: 5677badffc48a8d332e345ea4fe225e3577f53fc95deeec8306000b256829655 libtextcat-2.2.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper (assuming libtool is there) ? compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint output is OK. * final provides and requires are sane: libtextcat-2.2-4.fc8.x86_64.rpm libtextcat.so.0()(64bit) libtextcat = 2.2-4.fc8 = /sbin/ldconfig libtextcat.so.0()(64bit) libtextcat-devel-2.2-4.fc8.x86_64.rpm libtextcat-devel = 2.2-4.fc8 = libtextcat = 2.2-4.fc8 libtextcat.so.0()(64bit) * %check is not present; no test suite upstream. I have no way to test this package. * shared libraries installed; ldconfig is called properly and unversioned .so files are in the -devel package. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets OK (ldconfig). * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers are in the -devel package. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED; just add that libtool dependency. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review