https://bugzilla.redhat.com/show_bug.cgi?id=1368850 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from gil cattaneo <puntogil@xxxxxxxxx> --- Issues: - Package contains Requires: ruby(release). [!]: Gem package should exclude cached Gem. [!]: Test suite of the library should be run. [!]: Specfile should use macros from rubygem-devel package. Note: The specfile doesn't use these macros: %exclude %{gem_cache}, %{gem_libdir} NON blocking issues: [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD (2 clause) MIT/X11 (BSD like)". 237 files have unknown license. Detailed output of licensecheck in /home/gil/1368850-rubygem-rouge/licensecheck.txt All source files without license headers: Please, report to upstream [!]: License file installed when any subpackage combination is installed. Please, add also License file in doc sub package Please, fix before import Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx