https://bugzilla.redhat.com/show_bug.cgi?id=1368845 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from gil cattaneo <puntogil@xxxxxxxxx> --- Issues: - Package contains Requires: ruby(release). [!]: Gem package should exclude cached Gem. [!]: Test suite of the library should be run. [!]: Specfile should use macros from rubygem-devel package. Note: The specfile doesn't use these macros: %{gem_libdir}, %exclude %{gem_cache} NON blocking issues: [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/gil/1368845 -rubygem-forwardable-extended/licensecheck.txt Source files without license headers: forwardable-extended-2.6.0/lib/forwardable/extended.rb forwardable-extended-2.6.0/lib/forwardable/extended/version.rb Please, report to upstream [!]: License file installed when any subpackage combination is installed. Please, add also License file in doc sub package Please, fix before import Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx