[Bug 1366881] Review Request: ispc - C-based SPMD programming language compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1366881



--- Comment #14 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #13)
> > cc1plus: all warnings being treated as errors
> 
> -Werror is a very bad idea. It can be useful in upstream development, where
> you are using a specific version of the compiler, and want to catch any
> warnings as they appear. But in a package in a distribution, new warnings
> will appear as the compiler is updated and becomes smarter, so -Werror will
> cause constant breakage. Just remove it.

Done via patch. The compilation no longer failed. It turned out CXXFLAGS and
LDFLAGS were unnecessary on %make_build gcc lines as they were already in
Makefile. Here is the updated files

Spec URL: https://luya.fedorapeople.org/packages/SPECS/ispc.spec
SRPM URL:
https://luya.fedorapeople.org/packages/SRPMS/ispc-1.9.1-4.fc24.src.rpm

and the scratch build result
http://koji.fedoraproject.org/koji/taskinfo?taskID=15347603

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]