Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sos https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193712 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-07-06 00:14 EST ------- I think that in the new spec there's no reason to use --record or mess with INSTALLED_FILES because it's no longer being used. Generally the name of the package isn't used in the summary. The svn export doesn't match what's in the tarball. The tarball is missing Changelog, example_plugins, install-rpm.sh, Makefile, prep-rpm.sh, pylintrc, sosreport.1 and sos.spec. The checkout is missing PKG-INFO and sosreport.1.gz. Perhaps someone is compressing the manpage manually? There's no point; rpm will do it for you, and the %files section you have will handle it. I don't know about the rest of the mismatched files. The Changelog file seems to be something that should certainly be packaged. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review