[Bug 1366881] Review Request: ispc - C-based SPMD programming language compiler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1366881

Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(ignatenko@redhat.
                   |                            |com)



--- Comment #12 from Luya Tshimbalanga <luya@xxxxxxxxxxxxxxxxx> ---
So far g++ does not like this syntax on module.cpp:

module.cpp: In member function 'bool Module::writeOutput(Module::OutputType,
const char*, const char*, DispatchHeaderInfo*)':
module.cpp:1242:11: error: this 'if' clause does not guard...
[-Werror=misleading-indentation]
           if (strcasecmp(suffix, "c") && strcasecmp(suffix, "cc") &&
           ^~
module.cpp:1246:13: note: ...this statement, but the latter is misleadingly
indented as if it is guarded by the 'if'
             break;
             ^~~~~
module.cpp:1248:11: error: this 'if' clause does not guard...
[-Werror=misleading-indentation]
           if (strcasecmp(suffix, "c") && strcasecmp(suffix, "cc") &&
           ^~
module.cpp:1252:13: note: ...this statement, but the latter is misleadingly
indented as if it is guarded by the 'if'
             break;
             ^~~~~
g++ will complain about these parameters:

cc1plus: error: unrecognized command line option '-Wno-deprecated-register'
[-Werror]
cc1plus: error: unrecognized command line option '-Wno-c99-extensions'
[-Werror]
cc1plus: all warnings being treated as errors

Which can be disabled with included patch.

clang as compiler does not complain about the issue. Should we keep using gcc
or clang in that case? Upstream recommends the latter according to this link: 
https://github.com/ispc/ispc/wiki/Building-ispc:-Linux-and-Mac-OS-X

Perhaps making ispc available on the repo first should be the priority so you
can provide the fixes by removing clang as requirement.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]