[Bug 1366836] Review Request: webjars-locator-core - WebJar Locator Core functionality

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1366836



--- Comment #4 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Dennis Chen from comment #3)
> Issues:
> =======
> - Bundled jar/class files should be removed before build
>   Note: Jar files in source (see attachment)
>   See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
>   built_JAR_files_.2F_Other_bundled_software'
> 
> Section from link: "In particular *.class and *.jar files from upstream
> releases MUST NOT be used during build of Fedora packages and they MUST NOT
> be included in binary RPM. "
> 
> My understanding of the Packaging Guidelines says that a `find . -name
> "*.jar" -delete` before the build stage should be enough.

These are not bundled software.

./src/test/resources/jquery-2.1.1.jar
./src/test/resources/mailcheck-1.1.0.jar
./src/test/resources/permissions-jar.jar
./src/test/resources/no-permissions.jar

These are test resource in its preferable form for
editing, so it qualifies as source code IMHO.

Spec URL: https://gil.fedorapeople.org/webjars-locator-core.spec
SRPM URL: https://gil.fedorapeople.org/webjars-locator-core-0.31-2.fc24.src.rpm

- remove unused test resources

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]