[Bug 1368790] Review Request: perl-App-PFT - Hacker friendly static blog generator, command line utilities

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1368790

Giovanni <dacav@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |panemade@xxxxxxxxx
              Flags|                            |needinfo?(panemade@xxxxxxxx
                   |                            |m)



--- Comment #6 from Giovanni <dacav@xxxxxxxxxxxxxxx> ---
Hello Parag,

I've been applying your suggestions, which by the way turned out to be useful
also for Bug 1367569. I've got a couple of questions to ask about it, referring
to comment #3:

6) I'm not getting any issue by rpmlint. Once removed the `rm -rf %{buildroot}`
as by point 5, my %install looks like the following:

    %install
    make pure_install DESTDIR=%{buildroot}
    find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
    find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
    %{_fixperms} %{buildroot}/*
    install -d %{buildroot}%{_libexecdir}/%{name}

I was missing the %{_fixperms}, which is probably fixing the permissions, but I
compared the two RPMs with and without it (using rpm -qli), and the permission
looks the same.

I think I'm missing something. Could you please provide me with the error you
are getting from rpmlint?

7) I can use the install as suggested, but this will of course leave the
binaries in the %{buildroot}usr/bin/, and rpmbuild will complain about it. Do
you think I should go for install + rm?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]