[Bug 804125] Review Request: rdkit - A toolkit for cheminformatics and machine learning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=804125

Gianluca Sforna <giallu@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|                            |1293160



--- Comment #74 from Gianluca Sforna <giallu@xxxxxxxxx> ---
(In reply to Antonio Trande from comment #72)
> *************************
> cp -a python2 python3
> find python3 -name '*.py' | xargs sed -i '1s|^#!.*|#!%{__python3}|'
> find python2 -name '*.py' | xargs sed -i '1s|^#!.*|#!%{__python2}|'
> 
> # fix tests scripts for python3 runtime
> find python3 -name 'test_list.py' | xargs sed -i 's/"python"/"python3"/g'
> sed -i.orig 's/python/python3/g' python3/Projects/DbCLI/TestDbCLI.py
> *************************

Correct, but it hurts only space requirements on builders, I'd rather not add
more stuff to an already busy spec file.


> 
> - Fix this typo
> 
>         -D PYTHON_EXECUTABLE:FILEPATH=%{__python3} \
> %ifarch {%arm}    <----
>         -D RDK_OPTIMIZE_NATIVE:BOOL=OFF \

Done

> 
> - This package can't be built on epel7-pcc64le because of missing
>   'pandoc' package.

Looks like there is a bug for this:
https://bugzilla.redhat.com/show_bug.cgi?id=1293160


> 
> - epel6: "cc1plus: error: unrecognized command line option "-mpopcnt""
I will not build for anyway EPEL6 due to boost requirements

Stuff in the list looks very minor, but if you like I will post a -7
spec.package. How close do you think we are to a positive review?


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1293160
[Bug 1293160] Re-enable building on armv7hl
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]