[Bug 1364618] Review Request: embree - Collection of high-performance ray tracing kernels developed at Intel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1364618



--- Comment #16 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
You don't need to delete an empty dir from the installation root, rpm will just
ignore it.

Something is wrong with the way CXXFLAGS are set (right after pushd). Before it
before %cmake and that was working better.

%files is still busted. See #c14 for the right form :)
rpmlint goes all crazy:
embree-devel.x86_64: E: non-devel-file-in-devel-package
/usr/lib64/libembree.so.2.10.0
embree-devel.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libembree.so.2.10.0
embree-devel.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libembree.so.2.10.0

You cannot install the examples into /usr/bin. The names are too generic: e.g.
/usr/bin/convert is a well-known imagemagick executable. You can use
%_libdir/embree/examples instead.

+ package name is OK
+ license is acceptable (ASL 2.0)
+ license is specified correctly 
+ latest version
+ builds and install OK
+ provides/requires/BR look OK
- rpmlint is not happy (see above and below)

rpmlint:
embree.src:54: W: mixed-use-of-spaces-and-tabs (spaces: line 54, tab: line 1)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]