https://bugzilla.redhat.com/show_bug.cgi?id=1364618 --- Comment #14 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- This still doesn't build for me. I needed the following "patch": sed -r -i.bak 's/#include <math.h>/#include <cmath>/' common/math/constants.h sed -r -i.bak '/__forceinline float (abs|floor|ceil)/d' common/math/math.h The issue is that C++11 allows headers to define abs and similar functions in both :: and std::, so embree::abs(float) is ambigous with ::abs(float). I think it's also good to silence all warnings: -Wno-all in CXXFLAGS. Otherwise there's just too much noise. %files seems totally broken: - .so file must be in -devel - .so.* must be in the main package - %{_bindir}/%{name}/* doesn't match anything %files %license LICENSE.txt %doc README.md CHANGELOG.md readme.pdf %{_libdir}/libembree.so.2 %{_libdir}/libembree.so.2.* %files devel %{_libdir}/libembree.so %{_includedir}/embree2/ %{_libdir}/cmake/embree-%{version}/ What about the examples that are now built? Shouldn't they be run in %check, and packaged into -examples subpackage? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx