[Bug 1366355] Review Request: acme-tiny - Tiny auditable ACME script for Let's Encrypt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1366355



--- Comment #10 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
cert-chain-resolver is 150 lines, so making a package out of it seems a bit
overkill. OTOH, it is a separate project. I don't know what the best solution
is here.

OK, so you fixed python3 support. Now you should make the Fedora version use
python3 ;)
https://fedoraproject.org/wiki/Packaging:Python#Python_Version_Support says "If
a piece of software supports python3, it must be packaged for python3.". We
really shouldn't be adding more python2 stuff if we can avoid it.

Also, I'll reiterate the request to switch from cron to systemd timers: the
overhead is lower (less dependencies, less logs, less processes), and switching
from cron to systemd units is awkward, it can only be done between releases,
and the information whether a service was enabled or disabled is lost. So it's
better to do it properly from the start, i.e. use a systemd timer. I expect the
ones I pasted above to work without any issues.

You should include %shortcommit in the release tag
[https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Post-Release_packages].
Something like this works nicely to switch back and forth between tags and
releases:
%global gitcommit ea683512f9b82f2257770f0ed56d819eea230fc2
%{?gitcommit:%global gitcommitshort %(c=%{gitcommit}; echo ${c:0:7})}
Version:        123
Release:        4%{?gitcommit:.git%{gitcommitshort}}%{?dist}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]