https://bugzilla.redhat.com/show_bug.cgi?id=1367033 --- Comment #27 from Muayyad Alsadi <alsadi@xxxxxxxxx> --- > - Package could be pass by this way but I suggest that fixing make mechanism and using them because upstream has tests , so try to include tests in %%check unit I'll work with upstream with this regard. But this is outside the scope of this ticket. Because they use it as a statically linked file in their docker images (that's why they want to override default flags to make it statically linked regardless of your flags) > because upstream has tests , so try to include tests in %%check unit .. upstream tests require a running docker daemon. If compared to python-pymongo package, it has two sets of test, one that require a running mongo daemon and one does not. Fedora python-pymongo package only tests the second type. Regarding this packages, I guess there is no headless tests. > - Don't forget to clean spec from unneeded comments . I kept two comments, for the upsteam to be able to make packages for non-released versions. > You can fix make file as you want :) by sed or any way. hmmm, I can't see the value, this is a very simple single file c code, it does not need any kind of build systems like `make`. I guess it would be overkill to use their makefile Most of their makefile is not used to build it, but to help them maintain their github releases (generate tarballs, test it on their ubuntu specific docker images) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx