https://bugzilla.redhat.com/show_bug.cgi?id=1367825 --- Comment #3 from Zygmunt Krynicki <me@xxxxxxxxx> --- (In reply to Neal Gompa from comment #2) > A few things I see stand out: > > * Presets are supposed to be centrally managed in Fedora. Please remove the > preset from snapd and file a bug against fedora-release to add the snapd > preset. This is per Fedora policy: > https://fedoraproject.org/wiki/Packaging:DefaultServices Understood, will do. I removed the presets now. > * If you require specific kernel modules, please use their kmod provides. > For example, for squashfs, require "kmod(squashfs.ko)" instead of > kernel-modules. All the nice things that Fedora has :-). Updated to use this. > * Shouldn't modprobe be done before snapd is started? My understanding is > that snapd itself triggers the mounts of snaps, so modprobe should probably > occur as an ExecStartPre for snapd. Ha, yes. This probably also explains why the Fedora cloud images didn't work with snapd (because squashfs wasn't available early enough). Let me know if the modification I did is okay. > * I'm not sure it's a good idea to go and torch user data in the event snapd > is uninstalled. Can snapd be (theoretically) uninstalled and then installed > later and use the snaps/configs that already exist? If so, it *definitely* > makes no sense to purge everything like that. Yes it can be used as you described. Each distribution has different policy here, I'm totally happy to keep snapd state and state of particular snaps around (less scripts, less mistakes!). Updated spec file at: https://fedorapeople.org/~zyga/snapd.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx