https://bugzilla.redhat.com/show_bug.cgi?id=1367526 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review? --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- A few more fixes to make, all small. See below. (In reply to Paulo Andrade from comment #3) > Ok. Added the proper Obsoletes/Provides. Only sagemath uses it, so, > once a sagemath 7.3 package is available, polybori can be retired. I see Obsoletes/Provides for the -devel package, but not for the main package, nor for the python package. Shouldn't those Obsolete/Provide their polybori equivalents, too? > Thanks. Changed to use the suggested pattern, that indeed corrects the > problem. On not yet released versions it should actually make use of gd > and png. The current code base only uses gd if m4ri has not been built with png support (and the Fedora version does have such support). Are you saying that the next version will use gd anyway? > I believe this is more of something to ask upstream, it explicitly requires > python 2.7: > AM_PATH_PYTHON([2.7]) > so, I believe this is a work in progress by upstream. Okay. It would be nice to provide the python 3 version when it is available. > I used the sagemath SPKG.txt text, but indeed it was not looking right. > Now it was changed the Summary to the same as polybori, and description > basically s/PolyBori/BRiAl/. Note that the very last sentence of %description still uses the word PolyBoRi. Also, the bug title needs to match the %summary line before you request package creation. There is no changelog entry in the spec file for your latest version. Summary of changes to be made: 1. Obsoletes/provides for all packages, or a reason why that isn't needed. 2. Change one more instance of "PolyBoRi" in %description. 3. Add a changelog entry to the spec file for version 0.8.5-2. 4. Update the bug title with the current %summary in the spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx