[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1367033



--- Comment #16 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
(In reply to Muayyad Alsadi from comment #15)
> > * missing BuildRequires: gcc
> 
> I remember that the docs says you should assume this (to confirm go to any
> package in fedora which was built using GCC and gcc would always be implied
> not explicit)
> 
> BTW: I have validated it with mock on my laptop and on copr
Guidelines recently have been changed (almost half year ago I suppose) and it
requires listing of all BRs.
> 
> > Source0:        %{url}/archive/v%{version}/%{name}-%{version}.tar.gz
> 
> sure
> 
> > help2man --no-discard-stderr --include debian/help2man --no-info --name '%{summary}' ./%{name} > %{name}.1
> 
> why you removed the gzip? I have checked all manpages in fedora are
> compressed.
Because now it's gzip, in next year it might be xz. Compression is done
automatically by RPM.
> 
> > %doc %{_mandir}/man/%{name}.1*
> 
> wait, @cattaneo just told me to remove %doc on the man page
Then he's actually wrong. Man pages are documentation actually.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]